-
Notifications
You must be signed in to change notification settings - Fork 30.3k
read task cell should only need Data #88339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: graphite-base/88339
Are you sure you want to change the base?
Conversation
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
|
Allow CI Workflow Run
Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
736c5da to
d2375a3
Compare
bba22c0 to
17d5b7b
Compare
Merging this PR will not alter performance
Comparing Footnotes
|
Stats from current PR✅ No significant changes detected📊 All Metrics📖 Metrics GlossaryDev Server Metrics:
Build Metrics:
Change Thresholds:
⚡ Dev Server
📦 Dev Server (Webpack) (Legacy)📦 Dev Server (Webpack)
⚡ Production Builds
📦 Production Builds (Webpack) (Legacy)📦 Production Builds (Webpack)
📦 Bundle SizesBundle Sizes⚡ TurbopackClient Main Bundles: **431 kB** → **431 kB** ✅ -7 B82 files with content-based hashes (individual files not comparable between builds) Server Middleware
Build DetailsBuild Manifests
📦 WebpackClient Main Bundles
Polyfills
Pages
Server Edge SSR
Middleware
Build DetailsBuild Manifests
Build Cache
🔄 Shared (bundler-independent)Runtimes
|
d2375a3 to
8091f69
Compare
17d5b7b to
dc1a119
Compare
Failing test suitesCommit: 683ed33 | About building and testing Next.js
Expand output● create-next-app --app (App Router) › should create JavaScript project with --js flag ● create-next-app --app (App Router) › should create TypeScript project with --ts flag ● create-next-app --app (App Router) › should create project inside "src" directory with --src-dir flag ● create-next-app --app (App Router) › should create TailwindCSS project with --tailwind flag ● create-next-app --app (App Router) › should create an empty project with --empty flag ● create-next-app --app (App Router) › should create an empty TailwindCSS project with --empty flag
Expand output● Has CSS Module in computed styles in Development › should have CSS for page ● Can hot reload CSS Module without losing state › should update CSS color without remounting
Expand output● page features telemetry › detects --turbo correctly for ● page features telemetry › detects --turbo correctly for
Expand output● create-next-app --no-app (Pages Router) › should create JavaScript project with --js flag ● create-next-app --no-app (Pages Router) › should create TypeScript project with --ts flag ● create-next-app --no-app (Pages Router) › should create project inside "src" directory with --src-dir flag ● create-next-app --no-app (Pages Router) › should create TailwindCSS project with --tailwind flag ● create-next-app --no-app (Pages Router) › should create an empty project with --empty flag ● create-next-app --no-app (Pages Router) › should create an empty TailwindCSS project with --empty flag
Expand output● API routes › dev support › should not strip .json from API route ● API routes › dev support › should handle proxying to self correctly ● API routes › dev support › should respond from /api/auth/[...nextauth] correctly ● API routes › dev support › should handle 204 status correctly ● API routes › dev support › should render page ● API routes › dev support › should return 404 for undefined path ● API routes › dev support › should not conflict with /api routes ● API routes › dev support › should set cors headers when adding cors middleware ● API routes › dev support › should work with index api ● API routes › dev support › should return custom error ● API routes › dev support › should throw Internal Server Error ● API routes › dev support › should throw Internal Server Error (async) ● API routes › dev support › should parse JSON body ● API routes › dev support › should special-case empty JSON body ● API routes › dev support › should support boolean for JSON in api page ● API routes › dev support › should support undefined response body ● API routes › dev support › should support string in JSON response body ● API routes › dev support › should support null in JSON response body ● API routes › dev support › should return error with invalid JSON ● API routes › dev support › should parse bigger body then 1mb ● API routes › dev support › should support etag spec ● API routes › dev support › should parse urlencoded body ● API routes › dev support › should parse body in handler ● API routes › dev support › should parse body with config ● API routes › dev support › should show friendly error for invalid redirect ● API routes › dev support › should show friendly error in case of passing null as first argument redirect ● API routes › dev support › should redirect with status code 307 ● API routes › dev support › should redirect to login ● API routes › dev support › should redirect with status code 301 ● API routes › dev support › should return empty query object ● API routes › dev support › should parse query correctly ● API routes › dev support › should return empty cookies object ● API routes › dev support › should return cookies object ● API routes › dev support › should return 200 on POST on pages ● API routes › dev support › should return JSON on post on API ● API routes › dev support › should return data on dynamic route ● API routes › dev support › should work with dynamic params and search string ● API routes › dev support › should work with dynamic params and search string like lambda ● API routes › dev support › should prioritize a non-dynamic page ● API routes › dev support › should return data on dynamic nested route ● API routes › dev support › should 404 on optional dynamic api page ● API routes › dev support › should return data on dynamic optional nested route ● API routes › dev support › should work with child_process correctly ● API routes › dev support › should work with nullable payload ● API routes › dev support › should warn if response body is larger than 4MB ● API routes › dev support › should not warn if response body is larger than 4MB with responseLimit config = false ● API routes › dev support › should warn with configured size if response body is larger than configured size ● API routes › dev support › should compile only server code in development ● API routes › dev support › should show warning when the API resolves without ending the request in development mode ● API routes › dev support › should not show warning when the API resolves and the response is piped ● API routes › dev support › should show false positive warning if not using externalResolver flag ● API routes › dev support › should not show warning if using externalResolver flag
Expand output● next-config-ts-type-error-cjs › should throw with type error on build (CJS)
Expand output● next-config-ts-type-error-esm › should throw with type error on build (ESM)
Expand output● Invalid revalidate values › should not show error initially ● Invalid revalidate values › should not show error for false revalidate value ● Invalid revalidate values › should not show error for true revalidate value ● Invalid revalidate values › should show error for string revalidate value ● Invalid revalidate values › should show error for null revalidate value ● Invalid revalidate values › should show error for float revalidate value
Expand output● should parse JSON body ● should not throw if request body is already parsed in custom middleware ● should not throw if request's content-type is invalid
Expand output● Dynamic Optional Routing › development mode › rendering › should render catch-all top-level route with multiple segments ● Dynamic Optional Routing › development mode › rendering › should render catch-all top-level route with single segment ● Dynamic Optional Routing › development mode › rendering › should render catch-all top-level route with no segments ● Dynamic Optional Routing › development mode › rendering › should render catch-all nested route with multiple segments ● Dynamic Optional Routing › development mode › rendering › should render catch-all nested route with single segment ● Dynamic Optional Routing › development mode › rendering › should render catch-all nested route with no segments ● Dynamic Optional Routing › development mode › rendering › should render catch-all nested route with no segments and leading slash ● Dynamic Optional Routing › development mode › rendering › should match catch-all api route with multiple segments ● Dynamic Optional Routing › development mode › rendering › should match catch-all api route with single segment ● Dynamic Optional Routing › development mode › rendering › should match catch-all api route with no segments ● Dynamic Optional Routing › development mode › rendering › should match catch-all api route with no segments and leading slash ● Dynamic Optional Routing › development mode › rendering › should handle getStaticPaths no segments ● Dynamic Optional Routing › development mode › rendering › should handle getStaticPaths no segments and trailing slash ● Dynamic Optional Routing › development mode › rendering › should handle getStaticPaths 1 segment ● Dynamic Optional Routing › development mode › rendering › should handle getStaticPaths 1 segment and trailing slash ● Dynamic Optional Routing › development mode › rendering › should handle getStaticPaths 2 segments ● Dynamic Optional Routing › development mode › rendering › should handle getStaticPaths 2 segments and trailing slash ● Dynamic Optional Routing › development mode › rendering › should fall back to top-level catch-all ● Dynamic Optional Routing › development mode › rendering › should match root path on undefined param ● Dynamic Optional Routing › development mode › rendering › should match root path on false param ● Dynamic Optional Routing › development mode › rendering › should match root path on null param ● Dynamic Optional Routing › development mode › rendering › should handle getStaticPaths with fallback no segments ● Dynamic Optional Routing › development mode › rendering › should handle getStaticPaths with fallback 2 segments ● Dynamic Optional Routing › development mode › rendering › should fallback correctly when fallback enabled ● Dynamic Optional Routing › development mode › invalid pages › should fail to build when optional route has index.js at root ● Dynamic Optional Routing › development mode › invalid pages › should fail to build when optional route has same page at root ● Dynamic Optional Routing › development mode › invalid pages › should fail to build when mixed with regular catch-all ● Dynamic Optional Routing › development mode › invalid pages › should fail to build when optional but no catch-all
Expand output● next.rs api writeToDisk multiple times › should allow to write to disk multiple times ● next.rs api › should detect the correct routes ● next.rs api › should detect the correct routes ● next.rs api › should allow to write root page to disk ● next.rs api › should allow to write root page to disk ● next.rs api › should allow to write pages edge api to disk ● next.rs api › should allow to write pages edge api to disk ● next.rs api › should allow to write pages Node.js api to disk ● next.rs api › should allow to write pages Node.js api to disk ● next.rs api › should allow to write app edge page to disk ● next.rs api › should allow to write app edge page to disk ● next.rs api › should allow to write app Node.js page to disk ● next.rs api › should allow to write app Node.js page to disk ● next.rs api › should allow to write pages edge page to disk ● next.rs api › should allow to write pages edge page to disk ● next.rs api › should allow to write pages Node.js page to disk ● next.rs api › should allow to write pages Node.js page to disk ● next.rs api › should allow to write app edge route to disk ● next.rs api › should allow to write app edge route to disk ● next.rs api › should allow to write app Node.js route to disk ● next.rs api › should allow to write app Node.js route to disk ● next.rs api › should have working HMR on client-side change on a page 0 ● next.rs api › should have working HMR on client-side change on a page 0 ● next.rs api › should have working HMR on client-side change on a page 1 ● next.rs api › should have working HMR on client-side change on a page 1 ● next.rs api › should have working HMR on client-side change on a page 2 ● next.rs api › should have working HMR on client-side change on a page 2 ● next.rs api › should have working HMR on server-side change on a page 0 ● next.rs api › should have working HMR on server-side change on a page 0 ● next.rs api › should have working HMR on server-side change on a page 1 ● next.rs api › should have working HMR on server-side change on a page 1 ● next.rs api › should have working HMR on server-side change on a page 2 ● next.rs api › should have working HMR on server-side change on a page 2 ● next.rs api › should have working HMR on client and server-side change on a page 0 ● next.rs api › should have working HMR on client and server-side change on a page 0 ● next.rs api › should have working HMR on client and server-side change on a page 1 ● next.rs api › should have working HMR on client and server-side change on a page 1 ● next.rs api › should have working HMR on client and server-side change on a page 2 ● next.rs api › should have working HMR on client and server-side change on a page 2 ● next.rs api › should have working HMR on client-side change on a app page 0 ● next.rs api › should have working HMR on client-side change on a app page 0 ● next.rs api › should have working HMR on client-side change on a app page 1 ● next.rs api › should have working HMR on client-side change on a app page 1 ● next.rs api › should have working HMR on client-side change on a app page 2 ● next.rs api › should have working HMR on client-side change on a app page 2 ● next.rs api › should have working HMR on server-side change on a app page 0 ● next.rs api › should have working HMR on server-side change on a app page 0 ● next.rs api › should have working HMR on server-side change on a app page 1 ● next.rs api › should have working HMR on server-side change on a app page 1 ● next.rs api › should have working HMR on server-side change on a app page 2 ● next.rs api › should have working HMR on server-side change on a app page 2 ● next.rs api › should allow to make many HMR updates ● next.rs api › should allow to make many HMR updates ● Test suite failed to run
Expand output● React Context › should render a page with context ● React Context › should render correctly with context consumer ● React Context › should render with context after change
Expand output● 404 handling › custom _error › next dev › should normalize repeated slashes in redirects correctly ● 404 handling › custom _error › next dev › should handle double slashes correctly ● 404 handling › custom _error › next dev › should handle double slashes correctly with query ● 404 handling › custom _error › next dev › should handle double slashes correctly with hash ● 404 handling › custom _error › next dev › should handle double slashes correctly with encoded ● 404 handling › custom _error › next dev › should handle double slashes correctly with encoded and query ● 404 handling › custom _error › next dev › should handle double slashes correctly with encoded and hash ● 404 handling › custom _error › next dev › should handle backslashes correctly ● 404 handling › custom _error › next dev › should handle mixed backslashes/forward slashes correctly ● 404 handling › custom _error › next dev › should handle slashes in next/link correctly ● 404 handling › custom _error › next dev › should handle slashes in router push correctly ● 404 handling › custom _error › next dev › should have no error from encoded slashes in router push ● 404 handling › pages/404 › production mode › next dev › should normalize repeated slashes in redirects correctly ● 404 handling › pages/404 › production mode › next dev › should handle double slashes correctly ● 404 handling › pages/404 › production mode › next dev › should handle double slashes correctly with query ● 404 handling › pages/404 › production mode › next dev › should handle double slashes correctly with hash ● 404 handling › pages/404 › production mode › next dev › should handle double slashes correctly with encoded ● 404 handling › pages/404 › production mode › next dev › should handle double slashes correctly with encoded and query ● 404 handling › pages/404 › production mode › next dev › should handle double slashes correctly with encoded and hash ● 404 handling › pages/404 › production mode › next dev › should handle backslashes correctly ● 404 handling › pages/404 › production mode › next dev › should handle mixed backslashes/forward slashes correctly ● 404 handling › pages/404 › production mode › next dev › should handle slashes in next/link correctly ● 404 handling › pages/404 › production mode › next dev › should handle slashes in router push correctly ● 404 handling › pages/404 › production mode › next dev › should have no error from encoded slashes in router push
Expand output● Graceful Shutdown › development (next dev) › should shut down child immediately
Expand output● Non-Standard NODE_ENV › should not show the warning with NODE_ENV set to valid value (custom server) ● Non-Standard NODE_ENV › should show the warning with NODE_ENV set to invalid value (custom server)
Expand output● app-invalid-revalidate › should error properly for invalid revalidate at layout ● app-invalid-revalidate › should error properly for invalid revalidate at page ● app-invalid-revalidate › should error properly for invalid revalidate on fetch ● app-invalid-revalidate › should error properly for invalid revalidate on unstable_cache
Expand output● Switchable runtime › Switchable runtime (dev) › should not include edge api routes and edge ssr routes into dev middleware manifest ● Switchable runtime › Switchable runtime (dev) › should sort edge SSR routes correctly ● Switchable runtime › Switchable runtime (dev) › should be able to navigate between edge SSR routes without any errors ● Switchable runtime › Switchable runtime (dev) › should not consume server.js file extension ● Switchable runtime › Switchable runtime (dev) › should build /api/hello and /api/edge as an api route with edge runtime ● Switchable runtime › Switchable runtime (dev) › should be possible to switch between runtimes in API routes ● Switchable runtime › Switchable runtime (dev) › should be possible to switch between runtimes in pages
Expand output● API routes › dev support › should not strip .json from API route ● API routes › dev support › should handle proxying to self correctly ● API routes › dev support › should respond from /api/auth/[...nextauth] correctly ● API routes › dev support › should handle 204 status correctly ● API routes › dev support › should render page ● API routes › dev support › should return 404 for undefined path ● API routes › dev support › should not conflict with /api routes ● API routes › dev support › should set cors headers when adding cors middleware ● API routes › dev support › should work with index api ● API routes › dev support › should return custom error ● API routes › dev support › should throw Internal Server Error ● API routes › dev support › should throw Internal Server Error (async) ● API routes › dev support › should parse JSON body ● API routes › dev support › should special-case empty JSON body ● API routes › dev support › should support boolean for JSON in api page ● API routes › dev support › should support undefined response body ● API routes › dev support › should support string in JSON response body ● API routes › dev support › should support null in JSON response body ● API routes › dev support › should return error with invalid JSON ● API routes › dev support › should parse bigger body then 1mb ● API routes › dev support › should support etag spec ● API routes › dev support › should parse urlencoded body ● API routes › dev support › should parse body in handler ● API routes › dev support › should parse body with config ● API routes › dev support › should show friendly error for invalid redirect ● API routes › dev support › should show friendly error in case of passing null as first argument redirect ● API routes › dev support › should redirect with status code 307 ● API routes › dev support › should redirect to login ● API routes › dev support › should redirect with status code 301 ● API routes › dev support › should return empty query object ● API routes › dev support › should parse query correctly ● API routes › dev support › should return empty cookies object ● API routes › dev support › should return cookies object ● API routes › dev support › should return 200 on POST on pages ● API routes › dev support › should return JSON on post on API ● API routes › dev support › should return data on dynamic route ● API routes › dev support › should work with dynamic params and search string ● API routes › dev support › should work with dynamic params and search string like lambda ● API routes › dev support › should prioritize a non-dynamic page ● API routes › dev support › should return data on dynamic nested route ● API routes › dev support › should 404 on optional dynamic api page ● API routes › dev support › should return data on dynamic optional nested route ● API routes › dev support › should work with child_process correctly ● API routes › dev support › should work with nullable payload ● API routes › dev support › should warn if response body is larger than 4MB ● API routes › dev support › should not warn if response body is larger than 4MB with responseLimit config = false ● API routes › dev support › should warn with configured size if response body is larger than configured size ● API routes › dev support › should compile only server code in development ● API routes › dev support › should show warning when the API resolves without ending the request in development mode ● API routes › dev support › should not show warning when the API resolves and the response is piped ● API routes › dev support › should show false positive warning if not using externalResolver flag ● API routes › dev support › should not show warning if using externalResolver flag ● API routes › production mode › should show friendly error for invalid redirect ● API routes › production mode › should warn if response body is larger than 4MB ● API routes › production mode › should warn with configured size if response body is larger than configured size ● API routes › production mode › should warn with configured size if response body is larger than configured size
Expand output● streaming SSR with custom server › should render page correctly under custom server
Expand output● filesystem-caching with cache enabled › should cache or not cache loaders ● filesystem-caching with cache enabled › should cache or not cache loaders ● filesystem-caching with cache enabled › should allow to change files while stopped (RSC change) ● filesystem-caching with cache enabled › should allow to change files while stopped (RSC change) ● filesystem-caching with cache enabled › should allow to change files while stopped (RCC change) ● filesystem-caching with cache enabled › should allow to change files while stopped (RCC change) ● filesystem-caching with cache enabled › should allow to change files while stopped (Pages change) ● filesystem-caching with cache enabled › should allow to change files while stopped (Pages change) ● filesystem-caching with cache enabled › should allow to change files while stopped (rename app page) ● filesystem-caching with cache enabled › should allow to change files while stopped (rename app page) ● filesystem-caching with cache enabled › should allow to change files while stopped (next config change) ● filesystem-caching with cache enabled › should allow to change files while stopped (next config change) ● filesystem-caching with cache enabled › should allow to change files while stopped (env var change) ● filesystem-caching with cache enabled › should allow to change files while stopped (env var change) ● filesystem-caching with cache enabled › should allow to change files while stopped (RSC change, RCC change, Pages change, rename app page, next config change, env var change) ● filesystem-caching with cache enabled › should allow to change files while stopped (RSC change, RCC change, Pages change, rename app page, next config change, env var change)
Expand output● multi-zone › should correctly respond for / ● multi-zone › should correctly respond for /guest ● multi-zone › should correctly respond for /blog/post-1 ● multi-zone › should correctly respond for /guest/blog/post-1 ● multi-zone › should correctly respond for /guest/another/post-1 ● multi-zone › should support HMR in both apps
Expand output● runtime prefetching › in a page › can completely prefetch a page that uses cookies and no uncached IO |
8091f69 to
c751b5e
Compare
dc1a119 to
dad1033
Compare
dad1033 to
dab2e91
Compare
c751b5e to
193a825
Compare
5c0fe0f to
b9232ff
Compare
193a825 to
683ed33
Compare

No description provided.